BREAKING CHANGE: (#31) Removing the special nodes classes #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
May 9, 2024 16:59
ca11mejane
changed the title
|
upd: PR updated with the latest master; marked as ready |
Moootya
reviewed
Jun 17, 2024
Moootya
reviewed
Jun 17, 2024
Moootya
reviewed
Jun 17, 2024
vopankov
approved these changes
Aug 5, 2024
Moootya
approved these changes
Sep 6, 2024
Moootya
reviewed
Sep 6, 2024
ml_pipeline_engine/types.py
Outdated
| 'vectorize', | ||
| 'predict', | ||
| ) | ||
| RUN_METHOD_ALIAS = 'process' |
There was a problem hiding this comment.
I still have a question for this method. If we remove the ability to use different names in subclasses, I guess that we actually don't need to remain logic with a method's name as a string. We can just leave the abstract method "process" and use it. It will help understand codebase much faster and less painfully because the method is more explicit than the string name of the method
There was a problem hiding this comment.
ok, I've removed the constant, but I decided not to touch any other method dependencies; I suggest we take a look and decide what to eliminate from annotations in the next iteration
diff: edd533b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
resolves #31
Changes:
[DataSource, FeatureBase, MLModelBase, FeatureVectorizerBase, EventManagerBase,][NodeLike, ProcessorLike, DataSourceLike, FeatureLike, FeatureVectorizerLike, MLModelLike, NodeProtocol,][NodeBase.title,]PipelineChart(..., PipelineChartLike)andDAGPipelineContext(..., PipelineContextLike):